Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Guides home page's heading order #3838

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix the Guides home page's heading order #3838

merged 1 commit into from
Jun 7, 2024

Conversation

jasnakai
Copy link
Contributor

@jasnakai jasnakai commented May 23, 2024 •
edited
Loading

Pull request summary

Closes https://github.com/18F/TLC-crew/issues/724 for fixing heading order on the Guides home page.

Changes proposed in this pull request:

  • Changed card h3s to h2s to keep proper heading order.
  • Copied font styles from h3 and applied to card h2s only.
    • Makes no visible change and still matches the design file.

Reminder - please do the following before assigning reviewer

  • Update readme
  • For frontend changes, ensure design review
  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

@jasnakai jasnakai changed the title Fix Guides Heading Order Fix the Guides home page's heading order May 23, 2024
@jasnakai jasnakai requested review from adunkman, cantsin and dluetger and removed request for cantsin May 23, 2024 19:05
@jasnakai jasnakai marked this pull request as ready for review May 23, 2024 19:50
@jasnakai jasnakai requested a review from a team as a code owner May 23, 2024 19:50
dluetger
dluetger approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dluetger dluetger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

cantsin
cantsin approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpdesigns
Copy link
Member

@jasnakai following up on this. Anything else you need to close this?

@jasnakai jasnakai merged commit 25ad8fc into main Jun 7, 2024
5 checks passed
@jasnakai jasnakai deleted the jn/guides-headers branch June 7, 2024 18:32
@jasnakai
Copy link
Contributor Author

jasnakai commented Jun 7, 2024

@bpdesigns Thank you for checking in on that. I just merged the PR. I will close out the related ticket if I havent already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cantsin cantsin cantsin approved these changes

@dluetger dluetger dluetger approved these changes

@adunkman adunkman Awaiting requested review from adunkman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnakai @bpdesigns @cantsin @dluetger