Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playground badge, fix e2e badge #311

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add Playground badge, fix e2e badge #311

merged 2 commits into from
Aug 12, 2024

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Aug 8, 2024

Description of the Change

Adds a badge linking to a WP Playground instance instead of the release version badge and fixes the e2e badge to the right GH Action link.

How to test the Change

Use GH markdown previewer.

Changelog Entry

n/a

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.8.1 milestone Aug 8, 2024
@jeffpaul jeffpaul requested a review from dkotter August 8, 2024 21:41
@jeffpaul jeffpaul self-assigned this Aug 8, 2024
@jeffpaul jeffpaul requested a review from a team as a code owner August 8, 2024 21:41
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 8, 2024
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the Playground badge does not redirect to the "WP Playground instance." Should it?

@jeffpaul
Copy link
Member Author

jeffpaul commented Aug 9, 2024

@faisal-alvi good catch, I had the PG link in the wrong place

@dkotter dkotter merged commit 1a59e70 into develop Aug 12, 2024
12 of 13 checks passed
@dkotter dkotter deleted the add/playground branch August 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants