Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/295: Exclude 10up-lib from PHPCS linting #323

Merged
merged 5 commits into from
Jul 26, 2024
Merged

fix/295: Exclude 10up-lib from PHPCS linting #323

merged 5 commits into from
Jul 26, 2024

Conversation

Sidsector9
Copy link
Member

Description of the Change

Closes #295

This PR excludes 10up-lib directory from being linted by PHPCS as it is technically an external library.

How to test the Change

Run ./vendor/bin/phpcs . and ensure there are no errors.

Changelog Entry

Fixed - Disable linting on external libraries

Credits

Props @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 self-assigned this Jul 26, 2024
@github-actions github-actions bot added this to the 7.6.0 milestone Jul 26, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Jul 26, 2024
Copy link
Contributor

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@dkotter dkotter merged commit 10c29c2 into develop Jul 26, 2024
11 of 12 checks passed
@dkotter dkotter deleted the fix/295 branch July 26, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires feedback to determine next steps.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPCS linting failures
2 participants