Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an env:destroy command #35

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Add an env:destroy command #35

merged 3 commits into from
Aug 25, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Aug 23, 2023

Description of the Change

We have commands to start and stop an environment but it's also nice to have a command to destroy an environment once you're done with it. This PR adds that by default to the package.json file.

In addition, there were some issues with the newest version of wp-env which is installed when this project is used (and during our E2E tests). I didn't intend to fix those things as well but in order to get E2E tests to pass, a few minor changes were required there.

Alternate Designs

None

Possible Drawbacks

None

Verification Process

Check out this branch and set up a new project to ensure the command gets added

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - New command, env:destroy that is used to destroy an environment
Fixed - Addressed a few issues with the latest version of wp-env

Credits

Props @dkotter

@dkotter dkotter self-assigned this Aug 23, 2023
@dkotter dkotter requested a review from a team as a code owner August 23, 2023 20:51
@dkotter dkotter requested review from Sidsector9 and removed request for a team August 23, 2023 20:51
@dkotter dkotter added this to the 0.1.0 milestone Aug 23, 2023
@dkotter dkotter merged commit 9f2e5a9 into develop Aug 25, 2023
3 checks passed
@dkotter dkotter deleted the feature/add-npm-script branch August 25, 2023 14:44
@dkotter dkotter modified the milestones: 0.1.0, 0.2.0 Aug 25, 2023
@dkotter dkotter modified the milestones: 0.2.0, 0.1.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants