feature: add warning for executor cache config #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors/corporates @jhkimqd to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
jhkimqd
force-pushed
the
feature/executor-memory-warning
branch
from
bcef7b7
to
3b32b46
Compare
|
We require contributors/corporates @jhkimqd to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
jhkimqd
force-pushed
the
feature/executor-memory-warning
branch
from
3b32b46
to
7c5da01
Compare
|
We require contributors/corporates @jhkimqd to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
jhkimqd
force-pushed
the
feature/executor-memory-warning
branch
from
7c5da01
to
7831492
Compare
|
We require contributors/corporates @jhkimqd to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There has been some observations of the executor failing due to OOM in production environments. This was caused due to the executor configuration which allowed using more memory (as db caches pile up) than available. There is no warning about this, and this can be extremely hard to debug.
Suggestion
This PR aims to output a warning log if the executor is configured to use more than 50% of the available memory as cache, so developers will have a better idea on the consequences of their configs.