Feature/ongoing pp #354
Open
Feature/ongoing pp #354
+13,693
−4,698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update e2e with l1InfoTree + upgrade verifier to v2
Add more testing Refactor function overrite Refactor GlobalExitRoot contracts for dovereign chains First testing iteration sovereign chains Review fixes Review fixes II Review fixes III Full testing coverage for sovereign contracts Added sovereign bridge features - Batch call function implementation to remap multiple tokens - Allow migrating legacy to updated tokens natively - Added weth mapped address are initializer Refactor migrateLegacyToken function Coverage tests + fix 1_genesis script + typos Fix sovereign chain deployment at docker and removed struct Add remove ger function at sovereign GER contracts Review comment and add override at initialize function Refactor gerManagerSovereigns Create batch for pessimistic networks
Update bridge at create rollup for vanilla clients Review update
Package-lock Small fix upgrade rollupManager pessimistic script
Update deploy scripts with more checks Improve upgrade presimistic script
Sovereign bridge implementation
Upgrade sp1 verifier to v3 + improve comment at bridgev2
krlosMata
requested review from
invocamanman,
ignasirv and
laisolizq
as code owners
invocamanman
reviewed
Nov 5, 2024
deployment/testnet/prepareTestnet.ts
Outdated
| const gasTokenFactory = await ethers.getContractFactory("ERC20", deployer); | ||
| const gasTokenContract = await gasTokenFactory.deploy(gasTokenName, gasTokenSymbol); | ||
| await gasTokenContract.waitForDeployment(); | ||
| deployParameters.gasTokenAddress = gasTokenContract.target; |
There was a problem hiding this comment.
wasn't easier to modify jsut the createRollup file?¿
There was a problem hiding this comment.
Same difficult I guess, I thought we decided to put it on prepareTesnet script
invocamanman
reviewed
Nov 5, 2024
| @@ -29,13 +29,13 @@ contract PolygonRollupManagerNotUpgraded is PolygonRollupManager { | |||
| uint64 /*zkEVMForkID*/, | |||
| uint64 /*zkEVMChainID*/ | |||
| ) external reinitializer(2) { | |||
| pendingStateTimeout = _pendingStateTimeout; | |||
| trustedAggregatorTimeout = _trustedAggregatorTimeout; | |||
| //pendingStateTimeout = _pendingStateTimeout; | |||
There was a problem hiding this comment.
we could clean this contract ^^!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following: