Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limiting in verifyContracts.js #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bap2pecs
Copy link
Contributor

I got Failed to link proxy 0x<REDACTED> with its implementation. Reason: Max rate limit reached when i run the verify script.

root cause is that Etherscan API has:

image

@cla-bot cla-bot bot added the cla-signed label Sep 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@invocamanman
Copy link
Collaborator

Feel free to make similar changes to the current verify scripts, i didn't had the issue tho ^^ ( please make the changes on develop branch)
Thank you so much for your contributions, and sorry

@bap2pecs
Copy link
Contributor Author

@invocamanman believe this is due to I was using a free Etherscan plan which has a quite small rate limit. I will wait until I test out the v2 contracts deployment and see if I still get this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants