-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue7 ignore #13
Issue7 ignore #13
Conversation
…he case in _reported.js to skip in case skip is only-new and there is only new vars in the final report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing this thoroughly.
Needs a few changes before we can merge!
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for adopting the suggestions.
If you're interested in something more challenging, #8 is a super-useful feature.
Merging this.
@triggeredcode Added some initial explanation in #8 for |
Description
Added the parsing logic for the optional parameter --skip, if this flag is set true then same is conveyed to _reporter.js which in turn skips the write reports if the only flag is new
🌱
Fixes # (issue) #7
How Has This Been Tested?
Tested on all cases like :
: [ got the error as expected ]
: [ result as expected, skipped the write report ]
: [ result same as previous ]
Checklist:
.nvmrc
file and thenvm use
command).pre-commit install
to install the git hooks