Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue7 ignore #13

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Issue7 ignore #13

merged 4 commits into from
Dec 20, 2023

Conversation

triggeredcode
Copy link
Contributor

@triggeredcode triggeredcode commented Dec 15, 2023

Description

Added the parsing logic for the optional parameter --skip, if this flag is set true then same is conveyed to _reporter.js which in turn skips the write reports if the only flag is new 🌱

Fixes # (issue) #7

How Has This Been Tested?

Tested on all cases like :

  • bash lib/storage-delta/run.sh <COMMIT_OR_TAG> --skip : [ got the error as expected ]
  • bash lib/storage-delta/run.sh <COMMIT_OR_TAG> --skip only-new : [ result as expected, skipped the write report ]
  • bash lib/storage-delta/run.sh <COMMIT_OR_TAG> : [ result same as previous ]

Checklist:

  • I have used the proper Node.js version (e.g., using the .nvmrc file and the nvm use command).
  • I have formatted my code using prettier
  • I have installed pre-commit and have run pre-commit install to install the git hooks

…he case in _reported.js to skip in case skip is only-new and there is only new vars in the final report
Copy link
Member

@ZeroEkkusu ZeroEkkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this thoroughly.

Needs a few changes before we can merge!

run.sh Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
_reporter.js Outdated Show resolved Hide resolved
_reporter.js Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ZeroEkkusu ZeroEkkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for adopting the suggestions.
If you're interested in something more challenging, #8 is a super-useful feature.

Merging this.

@ZeroEkkusu ZeroEkkusu merged commit c846446 into 0xPolygon:dev Dec 20, 2023
1 of 2 checks passed
@ZeroEkkusu ZeroEkkusu mentioned this pull request Dec 20, 2023
@ZeroEkkusu ZeroEkkusu linked an issue Dec 20, 2023 that may be closed by this pull request
@triggeredcode
Copy link
Contributor Author

LGTM.

Thanks for adopting the suggestions. If you're interested in something more challenging, #8 is a super-useful feature.

Merging this.

It was a great, experience. Sure, let me get started on #8. Could you also add more context like you did for this issue, it would be very helpful.

@ZeroEkkusu
Copy link
Member

@triggeredcode Added some initial explanation in #8 for __gaps.

@ZeroEkkusu ZeroEkkusu mentioned this pull request Jan 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --ignore
3 participants