Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki docs migrated to Edge repo #2052

Merged
merged 14 commits into from
Dec 5, 2023
Merged

Conversation

kmurphypolygon
Copy link
Contributor

@kmurphypolygon kmurphypolygon commented Nov 24, 2023

Migrating wiki docs to Edge repo

  • New directory wiki-docs now includes a full static site of the current Edge docs on the wiki page.
  • You may wish to move this to the docs folder and incorporate the markdown file that is in there now.

Changes include

  • Moving the Edge docs to the Edge repo as part of the documentation rework project.

Checklist

  • [x ] I have added at least 1 reviewer

Testing

  • [ x] I have tested this code manually by running the site from the wiki-docs directory as per the README instructions there.

@gsilva5 @0xgraciegrace for review

Copy link

github-actions bot commented Nov 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kmurphypolygon
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kmurphypolygon
Copy link
Contributor Author

kmurphypolygon commented Nov 24, 2023

It looks like the build is breaking due to upstream code I didn't change.

There is another (smaller) issue which is that I had to add a user to the docker file to fix a security smell, however, this means that the docker script won't run as it requires root permissions.

wiki-docs/docs/api/json-rpc-debug.md Outdated Show resolved Hide resolved
wiki-docs/docs/contracts/reward-pool.md Outdated Show resolved Hide resolved
wiki-docs/docs/contracts/reward-pool.md Outdated Show resolved Hide resolved
wiki-docs/docs/contracts/state-receiver.md Outdated Show resolved Hide resolved
wiki-docs/docs/contracts/state-receiver.md Outdated Show resolved Hide resolved
wiki-docs/docs/interfaces/validators/root-validator-set.md Outdated Show resolved Hide resolved
wiki-docs/docs/interfaces/validators/validators.md Outdated Show resolved Hide resolved
wiki-docs/docs/interfaces/validators/validator-set-base.md Outdated Show resolved Hide resolved
wiki-docs/docs/operate/deploy/staking/stake.md Outdated Show resolved Hide resolved
wiki-docs/docs/operate/deploy/staking/stake.md Outdated Show resolved Hide resolved
@kmurphypolygon
Copy link
Contributor Author

kmurphypolygon commented Dec 1, 2023

Hi @goran-ethernal #2052 back to you.
Can we move this whole directory into the docs directory also? If yes, I can do it no probs, unless you want to.

Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, with regards that we have tasks for unresolved comments.

@kmurphypolygon You can move it to docs folder if you wan't to.

@Stefan-Ethernal Stefan-Ethernal merged commit 127381d into develop Dec 5, 2023
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@kmurphypolygon kmurphypolygon deleted the km/incorporate_docs branch December 5, 2023 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants