Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-749 Transaction pool Base Fee fix #1747

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Jul 25, 2023

Description

Transaction pool base fee was populated only on Prepare call. This method was called from the block builder when the node is the proposer.

After these changes, every time a new block is inserted into the chain, the base fee in the transaction pool is recalculated. This recalculation is performed inside the processEvent method, which is called by the ResetWithHeaders.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jul 25, 2023
@igorcrevar igorcrevar requested a review from a team July 25, 2023 10:13
@igorcrevar igorcrevar self-assigned this Jul 25, 2023
@igorcrevar igorcrevar marked this pull request as ready for review July 25, 2023 13:14
@igorcrevar igorcrevar merged commit 787cbe4 into develop Jul 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
@igorcrevar igorcrevar deleted the feature/txpool_base_fee_fix branch July 27, 2023 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants