Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestDiscovery_ConnectedPopulatesRoutingTable fix #1745

Merged
merged 3 commits into from
Jul 25, 2023
Merged

TestDiscovery_ConnectedPopulatesRoutingTable fix #1745

merged 3 commits into from
Jul 25, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

Just a fix for one unit test: The routing table is filled after peers connect to each other (and therefore populate their peers map). So, it is not enough to wait for the peers map to be populated.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jul 25, 2023
@igorcrevar igorcrevar requested a review from a team July 25, 2023 09:20
@igorcrevar igorcrevar self-assigned this Jul 25, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a couple of optional notes to consider.

network/discovery_e2e_test.go Outdated Show resolved Hide resolved
network/discovery_e2e_test.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar merged commit bbbe3ab into develop Jul 25, 2023
5 of 6 checks passed
@igorcrevar igorcrevar deleted the feature/discovery_test_fix branch July 25, 2023 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorcrevar @Stefan-Ethernal @goran-ethernal