Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-747]: eth_subscribe issue with LogIndex #1744

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[EVM-747]: eth_subscribe issue with LogIndex #1744

merged 1 commit into from
Jul 25, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jul 25, 2023 •
edited
Loading

Description

This PR fixes issue where eth_subscribe rpc call did not set LogIndex for block log at all.

This PR added a UT for this.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team July 25, 2023 08:14
@goran-ethernal goran-ethernal self-assigned this Jul 25, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Jul 25, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review July 25, 2023 08:14
@goran-ethernal goran-ethernal merged commit 2d3e101 into develop Jul 25, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-747-eth_subscribe_LogIndex_issue branch July 25, 2023 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@rachit77 rachit77 rachit77 approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goran-ethernal @vcastellm @igorcrevar @rachit77 @Stefan-Ethernal