Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test claimcalldata #64

Merged
merged 3 commits into from
Sep 12, 2024
Merged

update test claimcalldata #64

merged 3 commits into from
Sep 12, 2024

Conversation

laisolizq
Copy link
Collaborator

Description

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
72.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

vcastellm
vcastellm approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this the test here shouldn't manage the environment, the requirement for running this tests should be to have an l1 node running. Same as DB testing doesn't bother starting db engines!

@laisolizq laisolizq merged commit e24dadd into develop Sep 12, 2024
6 of 9 checks passed
@vcastellm vcastellm deleted the feature/test-claim-update branch September 17, 2024 09:44
Stefan-Ethernal pushed a commit that referenced this pull request Sep 17, 2024
@laisolizq @Stefan-Ethernal
update test claimcalldata (#64)
813dec8 
* update test claimcalldata

* fix test claimcalldata

* add tests claimcalldata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@arnaubennassar arnaubennassar arnaubennassar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laisolizq @vcastellm @arnaubennassar @Stefan-Ethernal