Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add module names to component loggers #60

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 4, 2024

Description

This PR includes the module metadata field for each module in the CDK stack: sequence-sender, aggregator, da-committee etc. which makes filtering of logs by certain components much easier.

@Stefan-Ethernal Stefan-Ethernal changed the title Add module names to component loggers feat: Add module names to component loggers Sep 4, 2024
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-449-cdk-components-should-have-their-own-log-files branch 3 times, most recently from 57bf8ac to dd981b3 Compare September 5, 2024 12:07
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review September 5, 2024 12:11
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/components.go Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-449-cdk-components-should-have-their-own-log-files branch from 591e401 to a886ec3 Compare September 16, 2024 10:49
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-449-cdk-components-should-have-their-own-log-files branch from 2b1d5d3 to bea4298 Compare September 16, 2024 11:05
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-449-cdk-components-should-have-their-own-log-files branch from bea4298 to 4346dc7 Compare September 16, 2024 11:11
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Stefan-Ethernal Stefan-Ethernal merged commit 803540b into develop Sep 16, 2024
8 of 9 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the CDK-449-cdk-components-should-have-their-own-log-files branch September 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants