-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add module names to component loggers #60
Merged
Stefan-Ethernal
merged 17 commits into
develop
from
CDK-449-cdk-components-should-have-their-own-log-files
Sep 16, 2024
Merged
feat: Add module names to component loggers #60
Stefan-Ethernal
merged 17 commits into
develop
from
CDK-449-cdk-components-should-have-their-own-log-files
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
Add module names to component loggers
feat: Add module names to component loggers
Sep 4, 2024
Stefan-Ethernal
force-pushed
the
CDK-449-cdk-components-should-have-their-own-log-files
branch
3 times, most recently
from
September 5, 2024 12:07
57bf8ac
to
dd981b3
Compare
Stefan-Ethernal
requested review from
arnaubennassar,
ToniRamirezM and
goran-ethernal
September 5, 2024 12:34
goran-ethernal
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
arnaubennassar
approved these changes
Sep 16, 2024
… the sequence sender
Stefan-Ethernal
force-pushed
the
CDK-449-cdk-components-should-have-their-own-log-files
branch
from
September 16, 2024 10:49
591e401
to
a886ec3
Compare
Stefan-Ethernal
force-pushed
the
CDK-449-cdk-components-should-have-their-own-log-files
branch
from
September 16, 2024 11:05
2b1d5d3
to
bea4298
Compare
Stefan-Ethernal
force-pushed
the
CDK-449-cdk-components-should-have-their-own-log-files
branch
from
September 16, 2024 11:11
bea4298
to
4346dc7
Compare
Quality Gate failedFailed conditions |
Stefan-Ethernal
deleted the
CDK-449-cdk-components-should-have-their-own-log-files
branch
September 16, 2024 12:01
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the
module
metadata field for each module in the CDK stack:sequence-sender
,aggregator
,da-committee
etc. which makes filtering of logs by certain components much easier.