-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Various pessimistic proofs fixes and adaption to kurtosis-cdk
pessimistic proof branch
#165
Open
goran-ethernal
wants to merge
17
commits into
develop
Choose a base branch
from
feature/adapt_kurtosis_pp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+615
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
feature/adapt_kurtosis_pp
branch
from
November 6, 2024 16:20
434abbd
to
73dfe95
Compare
goran-ethernal
force-pushed
the
feature/adapt_kurtosis_pp
branch
from
November 7, 2024 10:27
5242ecf
to
70aaaaf
Compare
joanestebanr
reviewed
Nov 7, 2024
goran-ethernal
force-pushed
the
feature/adapt_kurtosis_pp
branch
from
November 7, 2024 13:59
f4338f1
to
e2ff575
Compare
joanestebanr
approved these changes
Nov 7, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
InError
certificates. When a certificate is marked asInError
onagglayer
, we need to build a new one with the same height, that includes its bridges and claims, plus new ones that we saw in the meantime.Candidate
andProven
certificates were also settled on theagglayer
, because we cannot send a new one, until the previous one is either marked asInError
orSettled
.local_config
script to the newkurtosis-cdk
version.db
transaction in the theaggsender_storage
.Config changes
Parameter
SaveCertificatesToFiles
(bool) have been changed bySaveCertificatesToFilesPath
: if is = "" is disabled, if not it write certificated in the specific path