Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various pessimistic proofs fixes and adaption to kurtosis-cdk pessimistic proof branch #165

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Nov 6, 2024

Description

This PR includes:

  1. Fix for replacing InError certificates. When a certificate is marked as InError on agglayer, we need to build a new one with the same height, that includes its bridges and claims, plus new ones that we saw in the meantime.
  2. Fix for checking if Candidate and Proven certificates were also settled on the agglayer, because we cannot send a new one, until the previous one is either marked as InError or Settled.
  3. Adapting local_config script to the new kurtosis-cdk version.
  4. Fix where aggsender sent nil for imported bridge exits when it doesnt have any claims.
  5. Fix where we didn't rollback db transaction in the the aggsender_storage.

Config changes

Parameter SaveCertificatesToFiles (bool) have been changed by SaveCertificatesToFilesPath: if is = "" is disabled, if not it write certificated in the specific path

[aggsender]
SaveCertificatesToFilesPath = ""

@goran-ethernal goran-ethernal marked this pull request as ready for review November 7, 2024 12:08
agglayer/client.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants