fix: tests

0xPolygon · Sep 17, 2024 · bc4a1a4 · bc4a1a4
1 parent 75a4d19
commit bc4a1a4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/test/basic-e2e.bats b/test/basic-e2e.bats
@@ -25,11 +25,11 @@ setup() {
     local sender_balance=$(rpcQuery "balance" "--ether" "$senderAddr") || return 1
     local excessive_value=$(echo "$sender_balance + 1" | bc)ether
     run sendTx "$private_key" "$receiver" "$excessive_value"
-    assert_failure "Transaction should fail when attempting to transfer more than the sender balance"
+    assert_failure 
 
     # check wheather nonce of sender was updated correctly or not
     local final_nonce=$(rpcQuery "nonce" "$senderAddr") || return 1
-    assert_equal "$final_nonce" "$(echo "$initial_nonce + 1" | bc)" "Error nonce not updated correctly"
+    assert_equal "$final_nonce" "$(echo "$initial_nonce + 1" | bc)"
 }
 
 @test "Deploy ERC20Mock contract" {

diff --git a/test/helpers/common.bash b/test/helpers/common.bash
@@ -95,8 +95,8 @@ function sendTx() {
     fi
 
     # Check initial ether balance of sender and receiver
-    local sender_initial_balance=$(rpcQuery "balance" "$senderAddr" "latest") || return 1
-    local receiver_initial_balance=$(rpcQuery "balance" "$account_addr" "latest") || return 1
+    local sender_initial_balance=$(rpcQuery "balance" "$senderAddr" "--block latest") || return 1
+    local receiver_initial_balance=$(rpcQuery "balance" "$account_addr" "--block latest") || return 1
 
 
     # Check if the first remaining argument is a numeric value (Ether to be transferred)
@@ -155,7 +155,7 @@ function sendTx() {
         return 1
     fi
 
-    echo "Transaction successful (transaction hash: $tx_hash)"
+    echo "Transaction successful (transaction hash: '$tx_hash')"
 
     return 0
 }
@@ -231,19 +231,19 @@ function checkTransactionSuccess() {
     local sender_initial_balance="$5"
     local receiver_initial_balance="$6"
 
-    local sender_final_balance=$(rpcQuery "balance" "$senderAddr" "latest") || return 1
+    local sender_final_balance=$(rpcQuery "balance" "$senderAddr" "--block latest") || return 1
     local gas_used=$(cast tx "$tx_hash" --rpc-url "$rpc_url" | grep '^gas ' | awk '{print $2}')
     local gas_price=$(cast tx "$tx_hash" --rpc-url "$rpc_url" | grep '^gasPrice' | awk '{print $2}')
     local gas_fee=$(echo "$gas_used * $gas_price" | bc)
     local sender_balance_change=$(echo "$sender_initial_balance - $sender_final_balance" | bc)
 
-    echo "Sender's balance changed by: $sender_balance_change wei"
-    echo "Gas fee paid: $gas_fee wei"
+    echo "Sender balance changed by: '$sender_balance_change' wei"
+    echo "Gas fee paid: '$gas_fee' wei"
 
     if [[ "$value_or_function_sig" =~ ^[0-9]+(ether)?$ ]]; then
-        local receiver_final_balance=$(rpcQuery "balance" "$receiver" "latest") || return 1
+        local receiver_final_balance=$(rpcQuery "balance" "$receiver" "--block latest") || return 1
         local receiver_balance_change=$(echo "$receiver_final_balance - $receiver_initial_balance" | bc)
-        echo "Receiver's balance changed by: $receiver_balance_change wei"
+        echo "Receiver balance changed by: `$receiver_balance_change` wei"
 
         value_in_wei=$(cast --to-unit wei "$value_or_function_sig")
         assert_equal "$receiver_balance_chang" "$value_in_wei" "Error: receiver balance updated incorrectly."