forked from 0xPolygonHermez/zkevm-node
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/v0.7.3 #152
Open
arnaubennassar
wants to merge
135
commits into
develop
Choose a base branch
from
update/v0.7.3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update/v0.7.3 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check unsupported precompiles * downgrade prover * restore solc version * update SC * new errors * fix as workaround to close batch on tx oog (0xPolygonHermez#3271) Co-authored-by: agnusmor <[email protected]> * handle executor close batch * added sanity check closing an empty batch * change log --------- Co-authored-by: agnusmor <[email protected]>
* fix RPC closebatch executor error * fix close batch * fix close batch * fix close batch * fix close batch * fix close batch --------- Co-authored-by: agnusmor <[email protected]>
* fix executor error closebatch * fix linter --------- Co-authored-by: agnusmor <[email protected]>
* fix oog2 * fix oog2 for estimateGas --------- Co-authored-by: tclemos <[email protected]>
* execution mode * execution mode * execution mode
* fix deltaTimestamp when debug tx * fix deltaTimeStamp for unsigned txs execution for specific block * fix deltaTimeStamp for unsigned txs execution for specific block * Revert "fix deltaTimeStamp for unsigned txs execution for specific block" This reverts commit eb77e04. * Revert "fix deltaTimeStamp for unsigned txs execution for specific block" This reverts commit d2cfa78. * fix debug trace l1 info tree index and add l1 info tree data * move MockL1InfoRoot from sequencer to state to allow multiple components to use the same value --------- Co-authored-by: agnusmor <[email protected]>
* remove executor errors * readd check
* add new sequenceBatches parameters * update SMC Elderberry, contract dockers and genesis * elderberry seq-sender (0xPolygonHermez#3312) * elderberry seq-sender * updated prover image to v5.0.0-RC4 * increase timeout to e2e-group7 --------- Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: dPunisher <[email protected]>
* update prover image * udpate prover docker memory limits * downgrade prover * upgrade prover
* last l2 block by batch number * optimization * change returned err in query
…rusted node (0xPolygonHermez#3336) * add selector for trusted sync to check that batches correspond to the supported forkids
…tamp baches (0xPolygonHermez#3340) * synchronizer adopt GetLastL2BlockByBatchNumber to check elderberry bacthes tstamp
* reserved zk counters * new prover image * udpate counters names * udpate counters names * add gas used to reserved zkCounters * add ReservedZKCounters to pool trasactions
* add reserved zk counters to pool transaction * add reserved zk counters to pool transaction * correct migration test
…ygonHermez#3352) * return used if reserved counters are 0 * refactor * refactor
* fix initial sequenced batch event
* add executor reserved ZK counters * update prover image to v5.0.0-RC6 * fix typos * add check reserved counters when executing L2 block * remove closeBatch * update prover image v5.0.0-RC7 * fixes and logs improvements * update prover image v5.0.0-RC8
* decode old ETROG processBatches use ETROG contract * fix sanity genesis
* Add reasons to the field `state.batch.closing_reason` (issue 0xPolygonHermez#3243)
* Update datastream file fixes: end batch entry, previous L2 block timestamp, current batch number * Use GetFirstEventAfterBookmark
* refactor ds logs * update ds library to v0.2.3
…Hermez#3744) * Fix tx OOC (node level) for first empty L2 block in batch * change log level for ooc (node level) when adding tx to the worker * fix check OOC (node level) when preexecuting the tx in RPC * Fix linter and test
* fix releaser * goreleaser yaml update version 2 * fix goreleaser version * remove testnet.zip from releaser
* add l2blockend to DS * move l2blockend creation
…ly in trusted state (0xPolygonHermez#3750) * fix timestamp when querying zkevm_getBatchByNumer and the batch is only in trusted state * control timestamp to be returned for a batch in GetBatchTimestamp * fix ErrNotFound * fix state.ErrNotFound check * fix comments * fix GetRawBatchTimestamps * fix comments * fix GetRawBatchTimestamps return err
Stefan-Ethernal
approved these changes
Aug 20, 2024
config/network.go
Outdated
// L1: block number in which the rollup was created | ||
RollupCreationBlockNum uint64 `json:"rollupCreationBlockNumber"` | ||
// L1: block number in which the rollup manager was created | ||
RollupManagerCreationBlockNum uint64 `json:"rollupManagerCreationBlockNumber"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened with this parameter? We do not need it anymore? 🙂
rachit77
approved these changes
Aug 22, 2024
begmaroman
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.