Merge pull request #30 from IdrisHanafi/hotfix/pool-db-optimization

hotfix: prevent pool_db connections from accumulating
0xPolygon · Oct 4, 2023 · 5399f88 · 5399f88
2 parents 47ae596 + 97899ad
commit 5399f88
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/docs/config-file/node-config-doc.md b/docs/config-file/node-config-doc.md
@@ -314,9 +314,9 @@ to be read in order to provide the private keys to sign the L1 txs
 | **Additional items** | False              |
 | **Tuple validation** | See below          |
 
-| Each item of this array must be                      | Description                                                                          |
-| ---------------------------------------------------- | ------------------------------------------------------------------------------------ |
-| [PrivateKeys items](#EthTxManager_PrivateKeys_items) | KeystoreFileConfig has all the information needed to load a private key from a k ... |
+| Each item of this array must be                      | Description                                                                                   |
+| ---------------------------------------------------- | --------------------------------------------------------------------------------------------- |
+| [PrivateKeys items](#EthTxManager_PrivateKeys_items) | KeystoreFileConfig has all the information needed to load a private key from a key store file |
 
 #### <a name="autogenerated_heading_2"></a>6.3.1. [EthTxManager.PrivateKeys.PrivateKeys items]
 

diff --git a/pool/pgpoolstorage/policy.go b/pool/pgpoolstorage/policy.go
@@ -34,6 +34,8 @@ func (p *PostgresPoolStorage) CheckPolicy(ctx context.Context, policy pool.Polic
 	} else if err != nil {
 		return false, err
 	}
+
+	defer rows.Close()
 	if !rows.Next() { // should always be a row if the policy exists
 		return false, nil
 	}