Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail wazero integrate #1474

Open
wants to merge 43 commits into
base: sprint-1.18
Choose a base branch
from

Conversation

storybehind
Copy link
Collaborator

@storybehind storybehind commented Apr 25, 2024

Changes

  • API to generate thumbnail of given image. Accepts three parameters.
    Thumbnail(img []byte, width, height int)
    img -> byte array of image,
    width and height -> width and height of expected thumbnail image in pixels,

  • If it results in error, the second parameter (error) will be error message of string type.

  • Otherwise, the second parameter will always be null. The first parameter contains byte array of thumbnail image.

NOTE: The first parameter will be empty array if it's unsuccessful (e.g couldn't generate due to unsupported format). This can be used as a fallback mechanism to generate thumbnail in the frontend.

benchmark image.txt

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@storybehind storybehind marked this pull request as ready for review May 17, 2024 20:57
@storybehind storybehind changed the base branch from sprint-1.14 to sprint-1.15 May 25, 2024 09:47
@storybehind storybehind changed the base branch from sprint-1.15 to sprint-1.16 July 10, 2024 07:39
@storybehind storybehind changed the base branch from sprint-1.16 to sprint-1.17 September 4, 2024 12:03
@storybehind storybehind changed the base branch from sprint-1.17 to sprint-1.18 September 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants