Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseSpider references geolocation args before defining it #49

Open
VMRuiz opened this issue Apr 11, 2024 · 1 comment
Open

BaseSpider references geolocation args before defining it #49

VMRuiz opened this issue Apr 11, 2024 · 1 comment

Comments

@VMRuiz
Copy link
Contributor

VMRuiz commented Apr 11, 2024

BaseSpider is referencing geolocation argument here while is not defined yet. That makes impossible to re-use this class without using the geolocation parameter:

zyte-spider-templates/zyte_spider_templates/spiders/base.py

Line 42 in 281f1f5

if spider.args.geolocation:

@Gallaecio
Copy link
Contributor

Same for max_requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gallaecio @VMRuiz