Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma Drill Cannot Re-order Bills #688

Closed
BardezAnAvatar opened this issue Mar 2, 2023 · 6 comments · Fixed by #689
Closed

Plasma Drill Cannot Re-order Bills #688

BardezAnAvatar opened this issue Mar 2, 2023 · 6 comments · Fixed by #689

Comments

@BardezAnAvatar
Copy link

Describe the bug

The Plasma Drill cannot re-order any of its bills when installed along side Better Workbench Management mod. When a bill is selected ON ONLY THIS STATION, it instead re-orders... colonists

To Reproduce
Reproducibility: ?
Steps to reproduce the behavior:

  1. Install Better Workbench Management mod
  2. Place a Plasma Drill (maybe other drills, too?)
  3. Add several bills to the Plasma Drill
  4. Try to drag the bills to re-order
  5. Notice that colonists are moved instead. May have to drag the cursor to the bottom of the screen

Expected behavior
Bills should be movable

Actual Behavior
Bills will not be reorderable. Instead, the bill selection appears to redirect to colonists. See screenshots that show cursor over bills, but have floating colonist pawns dragged instead.

Screenshots
screenshot10
screenshot11
screenshot9

Rimworld (please complete the following information):

  • RimWorld Version: latest (1.4)
  • PRF Version: latest
  • Link to gist bug report:
  • Type:
  • Severity:

Modlist (please complete the following information):

  • Does this problem exist if only prf is installed: uncertain
  • Your modlist (if needed): Better Workbench Management
  • Do you know what mod conflicts?: Better Workbench Management

Additional context
Other workbenches and machines within PRF work properly (such as assemblers); I have noticed this bug for several generations of PRF over the past few years. I want to say, anecdotally, that I used to see an index out of bounds of array error message when dragging bills but I am not able to reproduce that error reporting behavior at this time.

@BardezAnAvatar
Copy link
Author

Dang. Cursor not appearing in the screenshots. The cursor is over the top bill and moves up and down, roughly by pixels equal to the displaced colonist in the top bar.

@Sn1p3rr3c0n
Copy link
Collaborator

it seems to reorder Colonists instead of Bills.
but since this works perfectly fine without Better Workbench Management i would assume the issue is on their end.
If i had to guess they either forgot to patch the correct Tab or their Patch broke.

@BardezAnAvatar
Copy link
Author

While possible, there is no patch in that mod for specific mods that I can see when looking at its source. It seems to be a highly irregular setup for the plasma drill.

I might take a look into both mods' source to see if I can track it down.

FYI, link to a bug report over in Improved Workbenches' GitHub

@Sn1p3rr3c0n
Copy link
Collaborator

Sn1p3rr3c0n commented Mar 2, 2023

  • recheck if we need ProjectRimFactory.AutoMachineTool.ITab_Bills2 in addition to ProjectRimFactory.SAL3.UI.ITab_SAL3Bills

Sn1p3rr3c0n added a commit that referenced this issue Mar 3, 2023
@Sn1p3rr3c0n
Copy link
Collaborator

ccda0c5 removes the additional BillTab.
The core issue still needs to be resolved by Better Workbench Management

@BardezAnAvatar
Copy link
Author

@Sn1p3rr3c0n I have a patch submitted over to Better Workbench Management; looks like it was building type and not bill type that was causing issues.

Sn1p3rr3c0n added a commit that referenced this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants