Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals: Connection handling too complicated #390

Open
jamadden opened this issue Dec 6, 2019 · 0 comments
Open

Internals: Connection handling too complicated #390

jamadden opened this issue Dec 6, 2019 · 0 comments
Assignees
Labels

Comments

@jamadden
Copy link
Member

jamadden commented Dec 6, 2019

There's the generic LoadConnection and StoreConnection objects, new in RS 3.0, that encapsulate the lifetime of a connection and its cursors. New code is using that.

Then there's the IDBDriver object that actually knows how to open connections and set various connection and driver-specific bits, including knowing how to get database warnings and such.

Finally, there's the original ConnManager adapter object which the Load and Store connections delegate most operations to, which in turn delegates most operations to the IDBDriver, but which also has some knowledge about things like isolation levels.

The responsibilities are not well factored and figuring out who does what can be confusing. I think perhaps the ConnManager needs to go away, with its responsibilities divided among the IDBDriver and Load and Store connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant