Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #57

Open
GupCa opened this issue Dec 14, 2023 · 1 comment
Open

Performance issues #57

GupCa opened this issue Dec 14, 2023 · 1 comment

Comments

@GupCa
Copy link

GupCa commented Dec 14, 2023

The number of js event listeners only increases during switching between component and directive view in the demo. The same issue is observed on prod in my project where ace wrapper is used. This is a marker of memory leak/performance gap for the user who stays longer on the page.

To reproduce:

  1. Go to the ngx-wrapper example app
  2. Open the Performance monitor tab in the Chrome dev tab
  3. Click the Switch to component/directive button multiple times
  4. Observe JS Event listeners graph goes higher each time, and unsubscribing doesn't happen much

It looks like a problem with Ace itself, but I'm creating this to check if fixing it from the wrapper is possible.

image

@OnecodexGitHubAdmin
Copy link

For me it seems like instance.destroy() is not called.
I tried to do this on my own in ngOnDestroy but this is already too late and there's no instance available anymore.
Please fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants