zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged. #1585
+328
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash#1571 The update to a shielding transaction causes the information that the output is considered change to be lost. This happens because the scanning process does not have access to any information about the inputs to the transaction, and so it does not recognize the output as change.
…ic migration state.
nuttycom
force-pushed
the
debug/is_shielding
branch
from
215d4d9
to
88b8f79
Compare
…scind that determination. This is a minimal and correct but incomplete fix for zcash#1571. Additional work to distinguish change outputs is necessary to update existing wallets that have made an incorrect change determination in the past.
nuttycom
force-pushed
the
debug/is_shielding
branch
from
88b8f79
to
cacbf26
Compare
…tly flagged when recording sent outputs. Fixes zcash#1571
nuttycom
force-pushed
the
debug/is_shielding
branch
from
cacbf26
to
0d82e1e
Compare
nuttycom
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 61.88% 61.95% +0.07%
==========================================
Files 149 150 +1
Lines 18946 18994 +48
==========================================
+ Hits 11724 11768 +44
- Misses 7222 7226 +4 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Oct 24, 2024
| // Complete the migration | ||
| init_wallet_db(st.wallet_mut().db_mut(), None).unwrap(); | ||
|
|
||
| // Ensure that the transaction metadata is still correct after the update produced by scanning. |
There was a problem hiding this comment.
What scanning update? AFAICT this test doesn't do one; it just checks that the unscanned shielding transaction's metadata is not altered by the migration. It might indeed be useful to have two tests for this migration: one that ensures correct data isn't altered, and one that ensures incorrect data gets fixed.
There was a problem hiding this comment.
Copy/paste error - this comment was correct in the test for the change from IS_NULL to MAX, and the test is the same.
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571