Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite wallet will never expire outputs from a tx that has no expiry height, even if it cannot be mined ("conflicted" in zcashd terminology) #1426

Open
daira opened this issue Jun 17, 2024 · 1 comment
Labels
A-wallet Area: light wallet backend.

Comments

@daira
Copy link
Contributor

daira commented Jun 17, 2024

@daira wrote at #1402 (comment) :

It could be that the spending tx is unmined and will not expire, but is dependent on another transaction that is unmined and will expire.

This is a pre-existing issue. I don't think there's any way to fix it from this side of the lightwalletd protocol. A full node will keep only transactions that could be mined in its mempool (subject also to ZIP 401 if the mempool becomes full), but a light client doesn't have enough information to do that.

This is another reason why I think it's basically unsafe to ever include funds from zero-conf transactions in balances, especially for a light client. The issue is actually more general: depending on an output from another expired transaction is only one reason why a transaction might never be minable.

@daira
Copy link
Contributor Author

daira commented Jun 21, 2024

The converse of this issue also applies to TXOs for which a spending transaction is unminable. That may be an inaccessible-funds issue. However, I think it only occurs when sharing a seed with another wallet that produces transactions that never expire.

@str4d str4d changed the title zcash_client_sqlite wallet will never expire outputs from a tx that has no expiry height, even if it cannot be mined zcash_client_sqlite wallet will never expire outputs from a tx that has no expiry height, even if it cannot be mined ("conflicted" in zcashd terminology) Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wallet Area: light wallet backend.
Projects
None yet
Development

No branches or pull requests

1 participant