Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Inconsistent behaviour for update_check_definition wtr to last_modified_by attribute #63

Open
ofreshy opened this issue Aug 31, 2017 · 0 comments
Labels
bug user-reported issues that take more than one hour to resolve Revisit relevant issue. Needs to be tackled as part of current stabilising work

Comments

@ofreshy
Copy link

ofreshy commented Aug 31, 2017

When updating check definition via the python client (but not via the command line cli), the 'last_modified_by' field is required.
The python docs only states that the owing team is required :

Proposed Solutions:

  • Update the docs to make it required by the python client
  • Attempt to read the user name if not provided (Similar to cmd line client)

I believe that the second option is better as more consistent with the cmd line client.

@mohabusama mohabusama added the bug user-reported issues that take more than one hour to resolve label Nov 16, 2017
@beverage beverage added the Revisit relevant issue. Needs to be tackled as part of current stabilising work label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug user-reported issues that take more than one hour to resolve Revisit relevant issue. Needs to be tackled as part of current stabilising work
Projects
None yet
Development

No branches or pull requests

3 participants