Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading svgbob 0.6.{5 → 6} breaks svgbobdoc #5

Open
yvt opened this issue Mar 16, 2022 · 1 comment
Open

Upgrading svgbob 0.6.{5 → 6} breaks svgbobdoc #5

yvt opened this issue Mar 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@yvt
Copy link
Owner

yvt commented Mar 16, 2022

https://docs.rs/crate/r3/0.2.0/builds/526363

error[E0599]: no method named `text` found for reference `&Node<&str, &str, svgbob::sauron::prelude::Leaf, &str, AttributeValue<()>>` in the current scope
   --> /opt/rustwide/cargo-home/registry/src/github.com-1ecc6299db9ec823/svgbobdoc-0.3.0-alpha.4/src/textproc.rs:297:47
    |
297 |                     if let Some(text) = child.text() {
    |                                               ^^^^ method not found in `&Node<&str, &str, svgbob::sauron::prelude::Leaf, &str, AttributeValue<()>>`

(edit: This particular breakage was fixed by #4)

@yvt yvt added the bug Something isn't working label Mar 16, 2022
@yvt yvt changed the title The latest svgbob ^0.6 breaks svgbobdoc? Upgrading svgbob 0.6.{5 → 6} breaks svgbobdoc Mar 16, 2022
@yvt
Copy link
Owner Author

yvt commented Mar 16, 2022

Pinning svgbob to a specific version (e.g., 0.6.5) will permanently resolve the issue. Pinning is also beneficial for maintaining stable rendering results, since It's hard to imagine that this is covered by semver guarantees, though pinning may negatively impact compilation times on the user's end and impede the application of bug fixes. I wonder if @ivanceras could provide some guidance on this.

yvt added a commit to r3-os/r3 that referenced this issue Mar 16, 2022
Fixes [the build error][1] that occurs when the `svgbobdoc/enable`
feature is enabled, and the version of `svgbob` specified by
`Cargo.lock` is `0.6.6`, which is newer than what `svgbobdoc
0.3.0-alpha.4` was originally written for but is still supposed to be
compatible as per semantic versioning.

[1]: yvt/svgbobdoc#5
yvt added a commit to r3-os/r3 that referenced this issue Mar 16, 2022
Fixes [the build error][1] that occurs when the `svgbobdoc/enable`
feature is enabled, and the version of `svgbob` specified by
`Cargo.lock` is `0.6.6`, which is newer than what `svgbobdoc
0.3.0-alpha.4` was originally written for but is still supposed to be
compatible as per semantic versioning.

[1]: yvt/svgbobdoc#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant