Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show Full Path in Footer #21

Open
MiracleXYZ opened this issue Aug 18, 2022 · 4 comments
Open

[Feature Request] Show Full Path in Footer #21

MiracleXYZ opened this issue Aug 18, 2022 · 4 comments

Comments

@MiracleXYZ
Copy link

MiracleXYZ commented Aug 18, 2022

Currently emgithub only shows the file name in the folder, which does not indicate the path structure. An option to show the full path of the file in the repository would be awesome.

e.g. https://github.com/user/repository/blob/branch/src/hello.cpp#L2-L6 -> src/hello.cpp instead of hello.cpp

@yusanshi
Copy link
Owner

Sounds like a good idea. While working on v2 of emgithub, I have implemented this feature (6a5dfd9). You can check it at https://emgithub.com/~

@MiracleXYZ
Copy link
Author

Appreciate it 👍

@MiracleXYZ
Copy link
Author

Some small improvements can be done though, like:

  1. Set the maximum path depth.
  2. Trim the path string if it gets too long.

@yusanshi
Copy link
Owner

I believe you mean when the path got too long as shown below...
image

However I think adding the option "Set the maximum path depth" may make the emgithub have too many options and too focused on the details.

I believe "Trim the path string if it gets too long" is preferred, such that when the text can't fit into one line it will get clipped and ellipsis is shown on the left. But text-overflow: ellipsis; will only trim the text on the right side. Use the direction:rtl; may do the trick but I think it may be too dirty... So currently I haven't got an effective and clean solution to this.

If you have got a better solution, PR is always welcomed.
If a dirty fix is suitable for your own use cases, you can fork the project and make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants