Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promdump: default tar filename has extra dash in custom metric mode #134

Open
ionthegeek opened this issue Jul 16, 2024 · 0 comments · May be fixed by yugabyte/prometheus-remote-backfill#31
Assignees
Labels
bug Something isn't working promdump Issues related to the prometheus-remote-backfill tools

Comments

@ionthegeek
Copy link
Contributor

ionthegeek commented Jul 16, 2024

When specifying --metric and --out to run in manual mode, the generated tar filename still includes both the dashes that would appear between the node prefix value and the other segments of the filename:

user@host:~$ ./promdump --end_time="2024-07-17T12:34:56Z" --debug --metric='{}' --out=custom
2024/07/16 15:43:34 promdump.go:892: promdump version DEV BUILD from commit POPULATED_BY_BUILD built POPULATED_BY_BUILD
2024/07/16 15:43:34 promdump.go:916: main: using the following flags: --debug=true --end_time=2024-07-17T12:34:56Z --metric={} --out=custom
2024/07/16 15:43:34 promdump.go:919: main: logging to file 'promdump.log'
2024/07/16 15:43:34 promdump.go:1032: Warning: The --node_prefix flag is deprecated. It is recommended to provide a --yba_api_token and use --universe_name or --universe_uuid instead.
2024/07/16 15:43:34 promdump.go:1086: main: not filtering by exported_instance
2024/07/16 15:43:34 promdump.go:205: main: skipping the following Yugabyte metrics: cql_export, master_export, node_export, platform, prometheus, tserver_export, ysql_export
2024/07/16 15:43:34 promdump.go:208: main: collecting the following custom metric: '{}'
2024/07/16 15:43:34 promdump.go:1103: main: tar bundling enabled
2024/07/16 15:43:34 promdump.go:1107: main: no --tar_filename specified; using filename 'promdump--20240716-154334.tar.gz'

The generateDefaultTarFilename() func should be updated to handle this case.

@ionthegeek ionthegeek added bug Something isn't working promdump Issues related to the prometheus-remote-backfill tools labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working promdump Issues related to the prometheus-remote-backfill tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants