Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be committing yarn.lock? #111

Open
chrishavlin opened this issue Oct 1, 2024 · 1 comment
Open

Should we be committing yarn.lock? #111

chrishavlin opened this issue Oct 1, 2024 · 1 comment

Comments

@chrishavlin
Copy link
Contributor

#110 was failing in CI related to no yarn.lock being checked in, so in that PR I modified the CI env variable enableImmutableInstalls to allow yarn.lock generation during install. Should figure out what the current standard for jupyter widgets is -- may be that we should be checking it in.

@chrishavlin
Copy link
Contributor Author

one point of info, the ts cookiecutter widget .gitignore only has the following

# NPM
# ----

**/node_modules/
{{ cookiecutter.python_package_name  }}/nbextension/index.*

# Coverage data
# -------------
**/coverage/

# Packed lab extensions
{{ cookiecutter.python_package_name  }}/labextension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant