Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor type-graphql authorization #2525

Open
3 tasks
yss14 opened this issue Mar 12, 2021 · 0 comments
Open
3 tasks

refactor type-graphql authorization #2525

yss14 opened this issue Mar 12, 2021 · 0 comments
Labels
backend refactoring v1.1 Planned for version v1.1

Comments

@yss14
Copy link
Owner

yss14 commented Mar 12, 2021

Motivation:
At the moment custom permission checks are solved via type-graphql middlewares and not the buildin auth checker functionality. This brings some disadvantages, like not being able to use buildin error handling behaviour and failing silently as proposed here.

Acceptance Criteria:

  • protected queries, mutations, and fields are decorated by the buildin type-graphql decorators
  • custom auth checker checks desired permissions
  • current workarounds are resolved where both errors and data is returned by a graphql query (e.g. feature: share settings see other users as member #2520)

Authoriztation Docs

@yss14 yss14 added backend refactoring v1.1 Planned for version v1.1 labels Mar 12, 2021
@yss14 yss14 mentioned this issue Mar 14, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend refactoring v1.1 Planned for version v1.1
Projects
None yet
Development

No branches or pull requests

1 participant