Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK v3.6.3 Update for NTESVerifyCodeManagerDelegate breaks the main functionality interface of the service #9

Open
blitzdex27 opened this issue Sep 3, 2024 · 3 comments

Comments

@blitzdex27
Copy link

blitzdex27 commented Sep 3, 2024

Hi, on v3.6.3, one of the delegate methods of NTESVerifyCodeManagerDelegate changed.

From:

- (void)verifyCodeValidateFinish:(BOOL)result validate:(NSString *_Nullable)validate message:(NSString *)message;

To:

- (void)verifyCodeValidateFinish:(BOOL)result validate:(NSString *_Nullable)validate message:(NSString *_Nullable)message captchaType:(NSString *_Nullable)captchaType;

It breaks the interface. Modifying the interface, especially one that involves the core functionality. might need a major version update and a notice to changes regarding the update. Because changing something like the above code will make the feature on apps that depends on this service to lose functionality.

Another thing, since this is the main handler delegate method, it might be better to make this method required instead of optional. This way, end users of this service will not be able to build their apps until they update their code.

Major Version: Indicates a significant change to the API or core functionality that may break existing code.
Minor Version: Indicates a new feature or enhancement that is backwards-compatible.
Patch Version: Indicates bug fixes or minor changes that don't affect the API or functionality.

https://semver.org

@luyud
Copy link

luyud commented Sep 13, 2024

Unbelievable, in version 3.6.4, they did it again, be careful ヽ(;´Д`)ノ

@blitzdex27
Copy link
Author

Unbelievable, in version 3.6.4, they did it again, be careful ヽ(;´Д`)ノ

Really? What was broken?

@luyud
Copy link

luyud commented Sep 13, 2024

They reverted to the previous method v3.6.2

- (void)verifyCodeValidateFinish:(BOOL)result validate:(NSString *_Nullable)validate message:(NSString *)message;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants