Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codable Protocol Instead #1

Open
decanus opened this issue Mar 14, 2019 · 2 comments
Open

Use Codable Protocol Instead #1

decanus opened this issue Mar 14, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@decanus
Copy link
Contributor

decanus commented Mar 14, 2019

To make the code more swift like, we should consider using codable types.

https://www.raywenderlich.com/382-encoding-decoding-and-serialization-in-swift-4

@decanus decanus added the good first issue Good for newcomers label Mar 14, 2019
@apbendi
Copy link

apbendi commented Mar 16, 2019

Hey @decanus, which types are you looking to implement Codable on? The Bases58 implementation itself seems to be a couple of extensions to String and Array, while the BigInt type from the dependency already implements Codable.

@decanus
Copy link
Contributor Author

decanus commented Mar 16, 2019

Instead of those ugly functions in String and Array extensions it would be cool if we could replace those with Codable code. Not sure if this is feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants