Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twice response to one query #487

Open
vadv opened this issue Apr 14, 2023 · 1 comment
Open

Twice response to one query #487

vadv opened this issue Apr 14, 2023 · 1 comment

Comments

@vadv
Copy link
Contributor

vadv commented Apr 14, 2023

It can be seen in tcpdump that two responses came to one client query.

in stream 270 tcp.stream eq 270:

  • query: packet number 202136
  • twice response: packet number 202175

CleanShot 2023-04-14 at 11 49 36@2x

tcpdump

@vadv
Copy link
Contributor Author

vadv commented Apr 17, 2023

here the fix:

From: Dmitry Vasiliev <[email protected]>
Date: Mon, 17 Apr 2023 17:12:26 +0300
Subject: [PATCH] fix backend reset

---
 sources/reset.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sources/reset.c b/sources/reset.c
index ff4424b..d92e63e 100644
--- a/sources/reset.c
+++ b/sources/reset.c
@@ -58,6 +58,10 @@ int od_reset(od_server_t *server)
 		if (server->relay.packet > 0)
 			goto error;

+		if (!od_server_synchronized(server)) {
+			goto drop;
+		}
+
 		while (!od_server_synchronized(server)) {
 			od_debug(&instance->logger, "reset", server->client,
 				 server,
--
2.40.0

UPD: that's not helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant