Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to async-profiler 2 #62

Open
loicmathieu opened this issue Aug 13, 2021 · 1 comment · May be fixed by #68
Open

Upgrade to async-profiler 2 #62

loicmathieu opened this issue Aug 13, 2021 · 1 comment · May be fixed by #68
Labels
enhancement New feature or request

Comments

@loicmathieu
Copy link
Contributor

Upgrade to async-profiler 2 for JVM application.
Version 2 supports HTML flamegraph which are easier to use.

I can try to provide a PR if you point me in the right direction, if I undertand it correctly, the Docker container image should be updated to use the new version. By the way, you build async-profiler from the source from a forked repo and not the official one, is there a reason why ?

@edeNFed
Copy link
Contributor

edeNFed commented Oct 5, 2021

Yes, you got it right.
The container that contains async-profiler is built here: https://github.com/yahoo/kubectl-flame/blob/master/agent/docker/jvm/Dockerfile

The fork repo is a workaround, back when I developed it async-profiler didn't work well with /tmp directory. If async-profiler version 2 works good we can remove this fork.

@edeNFed edeNFed added the enhancement New feature or request label Oct 5, 2021
@loicmathieu loicmathieu linked a pull request Oct 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants