You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of our code uses id as a variable name. This is bad practice because id is a built-in python function. We should change any use of id to something safe. My personal practice is to use idx or simply i, but even better is to use something more contextually relevant where possible.
For example, in uniform_hypergraph_configuration_model (as referenced in #617 that led to this issue), we could change id to node_id, since that is what the variable represents in this context.
One useful thing would be for someone to create a checklist of places where we need to make this change - can try to do it myself at some point, but also happy if someone beats me to it :)
The text was updated successfully, but these errors were encountered:
Some of our code uses
id
as a variable name. This is bad practice becauseid
is a built-in python function. We should change any use ofid
to something safe. My personal practice is to useidx
or simplyi
, but even better is to use something more contextually relevant where possible.For example, in
uniform_hypergraph_configuration_model
(as referenced in #617 that led to this issue), we could changeid
tonode_id
, since that is what the variable represents in this context.One useful thing would be for someone to create a checklist of places where we need to make this change - can try to do it myself at some point, but also happy if someone beats me to it :)
The text was updated successfully, but these errors were encountered: