Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of variable name id across the codebase #619

Open
tlarock opened this issue Nov 12, 2024 · 0 comments · May be fixed by #620
Open

Remove instances of variable name id across the codebase #619

tlarock opened this issue Nov 12, 2024 · 0 comments · May be fixed by #620

Comments

@tlarock
Copy link
Collaborator

tlarock commented Nov 12, 2024

Some of our code uses id as a variable name. This is bad practice because id is a built-in python function. We should change any use of id to something safe. My personal practice is to use idx or simply i, but even better is to use something more contextually relevant where possible.

For example, in uniform_hypergraph_configuration_model (as referenced in #617 that led to this issue), we could change id to node_id, since that is what the variable represents in this context.

One useful thing would be for someone to create a checklist of places where we need to make this change - can try to do it myself at some point, but also happy if someone beats me to it :)

@nwlandry nwlandry linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant