Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for non existent user #94

Open
zcgandcomp opened this issue Nov 16, 2023 · 2 comments
Open

Error handling for non existent user #94

zcgandcomp opened this issue Nov 16, 2023 · 2 comments

Comments

@zcgandcomp
Copy link
Member

When user is not exists in the UDS the 400 HTTP error code is returned.

We should return 404, or empty claims - TO BE Discussed
@zcgandcomp zcgandcomp changed the title Error handling for missing claims Error handling for non existent user Nov 16, 2023
@romanstrobl
Copy link
Member

romanstrobl commented Nov 16, 2023 •
edited
Loading

This seems to be a bad idea. The 404 error is reserved for the case when application is not running. It would not be possible to distinguish whether the application was not successfully deployed or the user does not exist, which are two very different states.

@romanstrobl
Copy link
Member

I suggest to use regular error handling with a specific error code for this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcgandcomp @romanstrobl