Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall with --deactivate flag #312

Open
craigtommola opened this issue Feb 1, 2022 · 3 comments
Open

Uninstall with --deactivate flag #312

craigtommola opened this issue Feb 1, 2022 · 3 comments
Labels
bug command:plugin-uninstall good-first-issue

Comments

@craigtommola
Copy link 

user@server:/data/blogs$ wp plugin uninstall google-analyticator --deactivate
Deactivating 'google-analyticator'...
Warning: Plugin 'google-analyticator' is network active and must be deactivated with --network flag.
Uninstalled and deleted 'google-analyticator' plugin.
Success: Uninstalled 1 of 1 plugins.

Despite the warning that a plugin was network active and must be deactivated with the --network flag, the plugin was in fact deleted. No skin off my nose, but it seems contradictory or unintended, based on the warning message.
@janw-me
Copy link
Member

janw-me commented May 29, 2022

A candidate for good-first-issue ?

@schlessera schlessera changed the title Uninstall with deactivate flag Uninstall with --deactivate flag Jun 2, 2022
@NielsdeBlaauw
Copy link

I'll be looking at this!

NielsdeBlaauw added a commit to NielsdeBlaauw/extension-command that referenced this issue Jun 2, 2022
@NielsdeBlaauw
Fixes wp-cli#312.
89ee56a 
When uninstalling a network activated plugin, the network tag is now added to correctly deactivate the plugin before removal.
@NielsdeBlaauw NielsdeBlaauw mentioned this issue Jun 2, 2022
Closed
@kkoppenhaver
Copy link
Contributor

As far as I can tell based on the conversation on #319, the patch needs to be re-applied and a test or two added.

The PR was closed during clean up, but appears to have been saved here: https://gist.github.com/danielbachhuber/f9aa4f759c7d57ff2663d07766241692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug command:plugin-uninstall good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: correctly deactivate network activated plugin before uninstall. NielsdeBlaauw/extension-command
5 participants
@schlessera @NielsdeBlaauw @janw-me @kkoppenhaver @craigtommola