Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the existing implementation #2

Open
HenryQuan opened this issue Oct 16, 2024 · 1 comment
Open

Review the existing implementation #2

HenryQuan opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@HenryQuan
Copy link
Member

This project was implemented two years ago, so it is good to do some review on this one. There are two approaches with this one. Either we can keep whatever it is done and add more things to the json or build a database? The API could also be compatible with Wargaming API, but it is not maintained that much anymore. Nim could also be used here since it is mostly pure logic but not necessary. More to be decided because this will be used in wowsinfo-core as part of the plan, wowsinfo/wowsinfo-core#2

@HenryQuan HenryQuan self-assigned this Oct 16, 2024
@HenryQuan
Copy link
Member Author

HenryQuan commented Oct 21, 2024

Julia can also be used to speed up the process if needed especially with all the huge loops. It can be use side by side with Python, setup is only required once. However, the file processing or running system command may not be the strength of Julia.

More to be decided what to do moving forward, the current API can be converted to a model first and see what to improve on, following WarGaming's endpoint will make the new system compatible with my existing app, meaning I can simply switch to my GitHub or host these files something to "fully replace" official wiki endpoints.

See the playground for the performance comparison with Python. Also, I can use LLM to convert the heavy generate.py into Julia or any language and see how it works, maybe I can get some quick POCs soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant