Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEATH KNIGHT] Death Strike Healing Improperly influenced by absorbed damage #880

Open
Shragenator opened this issue Jul 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Death Knight

Comments

@Shragenator
Copy link

The Bug:
Death strike is not behaving correctly in response to absorbed damage. Fully absorbed damage is counting it toward the "damage sustained during the preceding 5 seconds window" even though it should not.
A related behavior from cataclysm classic for death strike heal is also not replicated (see Death strike heal "snapshotting", below)

To Reproduce

  1. Create a template Blood dk character and replace all gems with mastery (increases likelihood of reproducing bug due to relatively higher shields to damage intake and min DS heal), and spidersilk spindle instead of symbiotic worm
  2. In the Settings tab, set the encounter as custom with 100k min base damage and 1.1 attack speed (a longer fight duration can also help to easier reproduce).
  3. Also in the settings tab, set the Incoming HPS to 13k, and the healing cadence to 1.5
  4. Run a single simulation, and ideally there should be 0% chance of death in the left.
  5. In results > timeline, scroll through the events timeline looking at the Blood shield uptime, and find a period of unbroken bloodshield (thus all damage during that time has been absorbed, also note the HP does not diminish by looking at the top HP row)
  6. Notice that sometimes in these instances of unbroken Blood shields, the heal value on a death strike will sometimes go UP even though all new damage has been absorbed. Additionally, in unbroken blood shields lasting longer than 5 seconds (and thus sustaining zero damage), death strike heal will be significantly above Min ds (7% of max hp)

Expected behavior
If there is an unbroken Blood shield, the death strike heal amount should never increase while the shield remains.

ADDITIONAL BEHAVIOR DETAIL: Death strike heal "snapshotting"
For up to 5 seconds after a death strike heal, any death strikes will heal for the same base amount as the death strike that triggered this window (before healing modifiers such as Vampiric blood). If any damage is sustained as magic or physical (the latter of which can be seen easily by a blood shield breaking), then this 5 second snapshot will end early.
Note that this is entirely distinct from the window that sums damage sustained in preceding 5 seconds.

This has been proven through behavior on cataclysm classic client as shown below:

https://classic.warcraftlogs.com/reports/ryjGp4X39ZBgDcPT#fight=last&view=events&start=272415&end=382114&type=summary&eventstart=347241
04:00.325 Brutallus Meteor Slash Assabellum 121072
04:01.276 Assabellum Death Strike Assabellum +35111
Then for about 4 seconds all attacks from brutallus are absorbed
04:05.699 Assabellum Death Strike Assabellum +35111

In addition to logs, this behavior can be seen with assistance from the following weakaura i have developed that attempts to reverse engineer death strike's healing. https://wago.io/oM8dggBX2


  • Simulations ran on browser version, Firefox Version 128.0.2 (64-bit)

Contact me directly if you would like assistance correcting the behavior of this ability.

@Shragenator Shragenator changed the title Death Strike Healing Improperly influenced by absorbed damage [DEATH KNIGHT] Death Strike Healing Improperly influenced by absorbed damage Jul 29, 2024
@rosenrusinov rosenrusinov self-assigned this Jul 29, 2024
@rosenrusinov rosenrusinov added bug Something isn't working Death Knight labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Death Knight
Projects
None yet
Development

No branches or pull requests

2 participants