New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect critical rate/dmg values #3

Open

Peacerekam opened this issue Nov 7, 2021 · 0 comments

Peacerekam commented Nov 7, 2021

After doing basic example

const genshin = require("genshin_panel");

let attribute = new genshin.AttributeBuilder()
    .character(keqing)
    .weapon(weapon)
    .artifact(art1)
    .artifact(art2)
    .artifact(art3)
    .artifact(art4)
    .artifact(art5)
    .build()

the attribute.critical and attribute.criticalDamage show incorrect values.

in crit dmg case it looks like calculation done is:
0.884 + 59 => 59.88 instead of 88.4 + 59 => 147,4

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment