Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize logging of HTTP interactions in the framework #148

Open
ghost opened this issue Apr 23, 2019 · 0 comments
Open

Standardize logging of HTTP interactions in the framework #148

ghost opened this issue Apr 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Apr 23, 2019 •
edited by ghost
Loading

Expected behavior

It should be possible to easily log the nature of HTTP invocations, including performance metrics, request & response content, and the like. This should be limited in Production contexts to both respect user privacy and conserve log resources.

URLSessionTaskDelegate might provide a centralized location to intercept requests & responses, as well as performance metrics via URLSessionTaskMetrics.

Actual behavior

At the moment, it is possible to inspect this information via manual debugging, but the logging in-place is not uniform. Performance metrics require manual instrumentation, as observed in this PR.

Steps to reproduce the behavior

N/A

WordPressKit Environment
  • WordPressKit Version : WordPressKit v4.0.0 & before
  • OS : iOS 10.x - 12.x
  • Device : all devices
  • Xcode Version : Xcode 10.2
Additional Context

N/A
@ghost ghost added the enhancement New feature or request label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants