Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try replacing async/await with .then() in Express Payments and CashApp Pay #217

Closed
Sidsector9 opened this issue Sep 10, 2024 · 1 comment
Closed

Try replacing async/await with .then() in Express Payments and CashApp Pay #217

Sidsector9 opened this issue Sep 10, 2024 · 1 comment

Comments

@Sidsector9
Copy link
Member

Describe the bug

With Woo 9.3 and React 18, both Digital Wallets and CashApp Pay broke for block Checkout. (See PR #216)
On discussing with Woo on Slack, it was suspected that using async/await could be the issue and they suggested to use .then() instead.

We should give this a try and see if it works.
@Sidsector9 Sidsector9 mentioned this issue Sep 10, 2024
Closed
4 tasks
@vikrampm1 vikrampm1 added the priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. label Sep 10, 2024
@Sidsector9
Copy link
Member Author

This issue may not be needed as Woo reverted the PR that introduced changes with React 18.

@vikrampm1 vikrampm1 removed the priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sidsector9 @vikrampm1