Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] "Sync inventory" button is displayed before the product is published #134

Open
qasumitbagthariya opened this issue May 27, 2024 · 3 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@qasumitbagthariya
Copy link
Contributor

qasumitbagthariya commented May 27, 2024

Describe the bug

The "Sync inventory" link-button is currently displayed in the product settings interface even when the product has not yet been published. This can cause confusion for users who might expect that syncing options are only relevant for published products. The enhancement request is to hide the "Sync" setting until the product is published.

To reproduce

  1. Goto Product > Add new
  2. Navigate to product data > general
  3. Enable Sync with square
  4. Goto inventory tab and check > stock management without publish a product

Screenshots

Screenshare.-.2024-05-27.7_37_03.PM.mp4

Expected behavior

  1. The "Sync" setting should only be displayed for products that have been published.
  2. This will ensure that users do not attempt to configure sync settings for unpublished products.
@jeffpaul
Copy link
Contributor

@qasumitbagthariya what if Square is the SOR and there are products there to push to Woo?

@qasumitbagthariya
Copy link
Contributor Author

@qasumitbagthariya what if Square is the SOR and there are products there to push to Woo?

When SOR Woocommerce or Square is used, this setting appears on both sides.

@vikrampm1 vikrampm1 added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. labels May 29, 2024
@Sidsector9 Sidsector9 changed the title [Enhancement] Sync Setting Displayed Without Publish Product [Enhancement] "Sync inventory" button is displayed before the product is published Jun 1, 2024
@Sidsector9
Copy link
Member

I've fixed the title and description.

@jeffpaul the issue is that we have a "sync inventory" button shown even before the product is even published. Syncing inventory won't work if the product is not published and synced to Square first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants