This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
is-loading
class is always attached to the filters
#7980
Labels
block-type: filter blocks
Issues related to all of the filter blocks.
team: Kirigami & Origami
type: bug
The issue/PR concerns a confirmed bug.
type: cooldown
Things that are queued for a cooldown period (assists with planning).
type: technical debt
This issue/PR represents/solves the technical debt of the project.
Steps to reproduce:
Actual:
There's
is-loading
class attached to the filters (check the screenshot)Expected:
There's no
is-loading
class attached to the filtersScreenshot
Investigation:
The class is added in the
save
method inindex.tsx
files of the filters, e.g:You can find it in filters patterns as well, so the rendered markup reflects the saved one.
This class is supposed to be removed by
renderBlock
function, however the container that comes in to this function is a filter wrapper, not the node to which theis-loading
class is assigned in the first place, hence it stays in there.Notes
is-loading
class to the wrapper it influences the editor as well (class is not removed there)The text was updated successfully, but these errors were encountered: