Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Improve screen reader support/provide another way to label selects #42

Open
barryhughes opened this issue Apr 16, 2021 · 0 comments
Open

[A11Y] Improve screen reader support/provide another way to label selects #42

barryhughes opened this issue Apr 16, 2021 · 0 comments

Comments

@barryhughes
Copy link
Member

Relates to WooCommerce #27317: when SelectWoo is applied to a <select> it will not be associated with the pre-existing <label> (assuming there was one) and, from the perspective of someone using a screen reader, the hint provided by that label is 'lost'.

Please see linked issue for an example based on usage of SelectWoo within WooCommerce's checkout form.
barryhughes added a commit that referenced this issue Apr 16, 2021
@barryhughes
Revert prematurely applied change per #42.
664698d 
This reverts commit 1fee4f2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barryhughes