Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinterest Tag tracking can be enabled even if Tag ID is not part of Commerce Integration with Pinterest. #1003

Open
message-dimke opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
type: enhancement The issue is a request for an enhancement. v5 Pinterest v5 related issue.

Comments

@message-dimke
Copy link
Contributor

message-dimke commented Apr 15, 2024

Describe the bug:

One can enable Pinterest Tag tracking even if the Tag ID is missing.

Steps to reproduce:

  1. Install Pinterest for WooCommerce plugin, which implements Pinterest v5 API.
  2. Initiate the Connect Wizard and skip Tag creation/selection during connection.
Cursor_and_Pinterest
  1. Check the Settings tab. Observe Track conversions setting is Off.
Settings_‹_Pinterest_‹_Marketing_‹_WooCommerce_‹_WordPress_Pinterest_—_WooCommerce
  1. Check database wp_options values for keys names pinterest_for_woocommerce and pinterest_for_woocommerce_data. Look for tag_id substring and observe empty values for:
  • tracking_tag inside pinterest_for_woocommerce key is empty;
  • tag_id inside pinterest_for_woocommerce_data key is empty;
  • connected_tag_id inside pinterest_for_woocommerce_data key is empty;
  1. Go to the Settings tab and enable Track conversions setting.
  2. Go to the Connection tab.
Connection_‹_Pinterest_‹_Marketing_‹_WooCommerce_‹_WordPress_Pinterest_—_WooCommerce
  1. Observe Track conversions with Pinterest Tag settings block at the bottom. See there is a Tag selected.
  2. Hit Save changes button.
  3. Check database wp_options values for keys names pinterest_for_woocommerce and pinterest_for_woocommerce_data. Look for tag_id substring and observe for:
  • tracking_tag inside pinterest_for_woocommerce key got the value;
  • tag_id inside pinterest_for_woocommerce_data key remained empty;
  • connected_tag_id inside pinterest_for_woocommerce_data key remained empty;
  1. Go to website frontend and observe Pinterest Tag events get fired with you navigate Shop pages or perform a Checkout.

NOTE: Track conversions with Pinterest Tag is an active block. If the application detects no Tag exists, it will automatically create it. Not all the values for options are going to be updated. The application is using tracking_tag from pinterest_for_woocommerce key value for Tag ID and saving Tag settings from the Connection tab will fill in that value.

NOTE: Also, when at the Settings tab, Enhanced Match support and Automatic Enhanced Match support are Tag related. However they are initialized with On values if Tag was not selected.

Expected behavior:

If Tag ID is empty or Pinterest commerce integration does not have it set, do not allow Tracking and Enhanced match settings to be changed. Do not allow Pinterest Tag events to be fired from the frontend if Tag is not a part of Commerce Integration with Pinterest.

@message-dimke message-dimke added the type: bug The issue is a confirmed bug. label Apr 15, 2024
@message-dimke message-dimke self-assigned this Apr 15, 2024
@message-dimke message-dimke changed the title Tracking can be enabled even if Tag ID is missing. Pinterest Tag tracking can be enabled even if Tag ID is not part of Commerce Integration with Pinterest. Apr 15, 2024
@message-dimke message-dimke added the v5 Pinterest v5 related issue. label Jul 26, 2024
@adarshakb
Copy link

This may be infact a feature, but we need to message it correctly that they will be enabling tag/conversions (and currently its disabled for them) if they perform this action

@message-dimke message-dimke added type: enhancement The issue is a request for an enhancement. and removed type: bug The issue is a confirmed bug. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement. v5 Pinterest v5 related issue.
Projects
None yet
Development

No branches or pull requests

2 participants