-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card #2603
Comments
@joemcgill I've added the IB and do you think we need the confirmation modal? Right now, when you want to create a new Ads account, the The IB has been written with the above in mind. Curious to hear your thoughts. |
@asvinb Given that at the point where we are showing this UI the user has already accepted terms (prior to connecting their Google account in #2566), I don't think an additional terms modal is necessary. I do think we should have an AYS modal just to keep someone from accidentally clicking that button. I think this will make the UI more consistent between the two types of account as well. |
Thanks @joemcgill . IB has been updated to reflect this. |
One additional suggestion is that we not refer to the "are you sure" modal as a I'm marking this as needs design until we can get confirmation for the "are you sure" modal text and the design for the UI while a new account is being created and will follow up with @fblascogarma and @michaeleleder. |
|
Everything else looks right to me. @eason9487 anything you'd add? |
The copy of "Create a new Google Ads account" in this status might need adjustment, like "Use another Google Ads account" or "Connect to a different Google Ads account". The same goes for the rest copy on the UI because it looks like it's still waiting to connect an account. |
@eason9487 Maybe we can update the copy during implementation? cc @joemcgill |
Good thinking, @eason9487. We'll need to add the ability to connect a different account for both the Ads and MC component after they're connected. @asvinb What do you think about including that in the scope of this issue and #2604, respectively? |
Sure thing @joemcgill . IB has been updated to account for the new button. |
@asvinb thanks! @eason9487 can you look at this one again as well? |
Looks good. Thanks for the updates! |
Caution
Blocked by #2596
Part of #2509
While connecting the store to Google Ads, a merchant may want to create a new account, even if they already have an existing Ads account associated with their Google account.
To support this, we will add a link below the account selector to kick off account creation.
Clicking this link should show an "Are you sure" modal, which lets them initiate account creation or cancel (screenshot shows an example of the Merchant Center modal, copy for the Ads modal TBD).
Once they confirm they want a new account, the account selector will replaced with a message that reads:
And the Connect button will be replaced by a loading spinner with the word "Creating..."
Once the account is created, we'll display the Claim you account UI:
Once the new account is created and reclaimed, the card will show the new account as connected
Acceptance Criteria
Implementation Brief
ConfirmCreateModal
component in the same folder as theConnectAds
component created in Onboarding: Connect to existing Ads account in Google Accounts Card #2596.js/src/components/google-mc-account-card/warning-modal/index.js
with updated copy.ConnectAds
component created in Onboarding: Connect to existing Ads account in Google Accounts Card #2596,ConfirmCreateModal
should be rendered, prompting the user's confirmation.upsertAdsAccount
function from theuseUpsertAdsAccount
hook.js/src/components/google-ads-account-card/create-account.js
ClaimAccount
component which was created in Onboarding: Connect to existing MC account in Google Accounts Card #2597 within theConnectAds
component.fetchConnectAdsAccount
function via theuseApiFetchCallback
hook.js/src/components/google-ads-account-card/connect-ads/index.js
on how to pass the new Google Ads ID touseApiFetchCallback
useGoogleAdsAccount
hook.js/src/components/google-ads-account-card/disconnect-account.js
and the possibility of re using theDisconnectAccount
component.Test Coverage
Definition Questions
The text was updated successfully, but these errors were encountered: