Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally connect Ads account during campaign creation #2578

Closed
5 tasks
Tracked by #2459
joemcgill opened this issue Sep 4, 2024 · 3 comments
Closed
5 tasks
Tracked by #2459

Optionally connect Ads account during campaign creation #2578

joemcgill opened this issue Sep 4, 2024 · 3 comments
Assignees

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Sep 4, 2024

As a follow-up to #2534 and #2535, once the component responsible for creating campaigns during onboarding is consolidated with the one used for creating and editing a campaign after onboarding, there is a need for that screen to handle cases where the Ads account has been disconnected from the settings screen.

To handle connecting an Ads account during campaign creation, we will optionally show the Google Ads account card on the campaign creation page if no account is connected (see related conversation).

Image

Acceptance Criteria

  • If an Ads account is already connected when entering the campaign creation form, no Google Ads account card should be shown.
  • When no Google Ads account is connected, the Google Accounts card is shown in its unconnected state and all other form fields are disabled.
  • The merchant can use the Ads card to connect an existing account or create a new account.
  • If a new account is created from this flow, the merchant can complete the claim account flow.
  • Once connected, the Google Ads card will show in a connected state.

Implementation details

This should be based from the work in this feature branch: feature/2460-simplify-paid-ads-setup

Test Coverage

Definition Questions

@joemcgill
Copy link
Collaborator Author

@fblascogarma and @MatthiasReinholz, I've started to stub out a ticket to handle the concerns @eason9487 raised in #2534 (comment).

Optionally adding some UI to this page to handle connecting an Ads account that was disconnected via the settings screen is an elegant solution and would allow the whole flow to remain consolidated to a single step. However, this does add a lot of additional complexity to this UI, so I wanted to confirm that we want to move forward with this approach rather than just keeping the first step in this flow (being removed in #2534) and instead optionally show that step if the Ads account is disconnected.

@joemcgill joemcgill added the needs feedback The issue/PR needs a response from any of the parties involved in the issue. label Sep 4, 2024
@fblascogarma
Copy link
Collaborator

Thank you for the question @joemcgill ! Fine by me on having that additional first step if we identify there isn't an Ads account connected yet.

@joemcgill joemcgill removed the needs feedback The issue/PR needs a response from any of the parties involved in the issue. label Sep 9, 2024
@joemcgill
Copy link
Collaborator Author

Great, thanks @fblascogarma. I'm going to close this issue as not planned for now, and we'll update #2534 to allow the original step to remain shown if no account is connected.

@joemcgill joemcgill closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants