-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Campaign Creation: Remove Ads Audience field #2501
Comments
I think there shouldn't be any side effects because the target audiences from MC are originally the default value when the starting campaign creation. |
There is a code conflict so I moved this ticket to the In Progress status. I believe the PR won't need another round of code reviews after resolving the code conflict. |
Thanks @eason9487 . Merge conflicts fixed. As per your comment, assigning task to @fblascogarma for UAT. |
Part of #2459
Today we show “Ads audience” (see screenshot below) but instead, we can remove it and target all countries selected during product feed configuration (step 2).
Acceptance Criteria
Implementation Brief
The
AudienceSection
component can be removed from thePaidAdsSetupSections
component. Update thePaidAdsSetupSections
component so that it initializes thepaidAds
state with targetAudience data that was saved in step 2. We can probably use thegetTargetAudience
selector to get this data, but will need to make sure that it then gets formatted in a way that is expected when the form is submitted.Test Coverage
Update the E2E tests for
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
to remove tests related to the audience field.The text was updated successfully, but these errors were encountered: